Fix highlight range computation for non-ascii characters#2742
Merged
Conversation
Fixes #2740 We were previously matching on the less specific 2-byte unicode point values, but this meant that something with with a 3 or 4 byte value (asian characters or emoji) would be first offset by 2 then loop incorrectly looking at the next character. The fix is to look for the largest byte match first and then narrow down to the smaller bit matches.
lucasderraugh
commented
Dec 29, 2025
| remaining = 3; | ||
| } else if (TEST_BITS(byte, 0b11110000)) { | ||
| remaining = 4; | ||
| if (TEST_BITS(byte, 0b11111100)) { |
Collaborator
Author
There was a problem hiding this comment.
5 and 6 technically aren't in the standard but might as well keep them 🤷♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2740
We were previously matching on the less specific 2-byte unicode point values, but this meant that something with with a 3 or 4 byte value (asian characters or emoji) would be first offset by 2 then loop incorrectly looking at the next character.
The fix is to look for the largest byte match first and then narrow down to the smaller byte matches.